Adds an overview section for loss detection and restructures a bit #397
Conversation
| # Loss Detection | ||
|
|
||
| We now describe QUIC's loss detection as functions that should be called on | ||
| packet transmission, when a packet is acked, and timer expiration events. | ||
| ## Overview {#overview} |
There was a problem hiding this comment.
You don't need a specific overview section here. The overview can go in the top-level section. My technical writing teacher say that it is bad form to include empty sections, even if they have child sections, so you can avoid two problems. Also, I assume that you need an overview for congestion control as well, so you avoid creating two sections with the label "overview".
|
|
||
| ## Algorithm Details | ||
|
|
||
| ### Constants of interest |
There was a problem hiding this comment.
Try to maintain a consistent use of Title Case or Sentence case for headings. Ideally we would be consistent with the style guide, which recommends the former.
| any retransmittable packet is outstanding. When this alarm fires, all | ||
| unacknowledged packets are marked as lost. | ||
|
|
||
| * Instead of a packet threshold to tolerate reordering, a QUIC sender may use |
There was a problem hiding this comment.
I think it makes sense to either place this as bullet 2 or merge it into the first bullet.
| reordering and then marks any unacknowledged packets as lost. This mechanism | ||
| is based on the Linux implementation of TCP Early Retransmit. | ||
|
|
||
| * If a packet is sent at the tail, there are no packets sent after it, and the |
There was a problem hiding this comment.
We don't mark any packets lost in this case until an ack is received.
|
|
||
| ## Constants of interest | ||
| * If all else fails, a Retransmission Timeout (RTO) alarm is always set when |
There was a problem hiding this comment.
That's not really true. We only arm the RTO if we've exceeded max TLP and early retransmit timer and time loss detection don't apply.
| QUIC uses a combination of ack information and alarms to detect lost packets. | ||
| An unacknowledged QUIC packet is marked as lost in one of the following ways: | ||
|
|
||
| * A packet is marked as lost if at least one packet that was sent a threshold |
There was a problem hiding this comment.
I find this sentence a bit hard to read. Is it possible to change these bullets to be structured in parallel and all begin with When?
ie: "When a packet sent more than a threshold number of packets(kReorderingThreshold) after an unackowledged packet is acknowledged."
martinthomson
added
the
editorial
No description provided.