Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cite the second reason bytes_in_flight might exceed CWND #4006

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Cite the second reason bytes_in_flight might exceed CWND #4006

merged 1 commit into from
Aug 18, 2020

Conversation

ianswett
Copy link
Contributor

Fixes #4004

@ianswett ianswett added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Aug 17, 2020
martinthomson
martinthomson approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Simple :)

@ianswett ianswett merged commit b0be3ff into master Aug 18, 2020
@ianswett ianswett deleted the ianswett-cwnd-limit-consistency branch August 18, 2020 23:02
@ianswett
Copy link
Contributor Author

We may want to revert this once #3978 lands

@janaiyengar
Copy link
Contributor

janaiyengar commented Aug 31, 2020 •
edited
Loading

#3978 still allows you to reduce the cwnd on entering recovery, so I think this text is still good.

Now that I've seen your changes to #3978, reverting this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaiyengar janaiyengar janaiyengar approved these changes

@martinthomson martinthomson martinthomson approved these changes

@kazuho kazuho kazuho approved these changes

Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two reasons to exceed bytes in flight
4 participants
@ianswett @janaiyengar @kazuho @martinthomson