Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type the artwork #403

Merged
merged 1 commit into from
Mar 14, 2017
Merged

type the artwork #403

merged 1 commit into from
Mar 14, 2017

Conversation

reschke
Copy link
Contributor

@reschke reschke commented Mar 14, 2017

No description provided.

@MikeBishop
Copy link
Contributor

MikeBishop commented Mar 14, 2017

Seems to add indents to the code blocks, but otherwise doesn't change the output. Not opposed, but not seeing any particular benefit, either. Does kramdown do something special with the types?

@MikeBishop
Copy link
Contributor

Note that prefixing with 4+ spaces makes it a code block in kramdown, but putting the ~~~/~~~ around it makes it take the spaces literally, which is why the indent shows up.

@reschke
Copy link
Contributor Author

reschke commented Mar 14, 2017

The types propagate to type attributes on artwork, which in turn are used by rfc2629.xslt to use different CSS styles.

I did not intend to change anything in the TXT output.

Note that adding "type='abnf'" will trigger a correct warning in rfc2629.xslt, as the draft currently does not cite RFC 5234.

@MikeBishop
Copy link
Contributor

Ah, I see. Okay, that's fine. I'll probably remove the spaces, then -- they're not needed if we have the tildes.

@MikeBishop MikeBishop merged commit 21cc94b into quicwg:master Mar 14, 2017
@reschke reschke deleted the patch-5 branch March 15, 2017 07:56
MikeBishop pushed a commit that referenced this pull request Mar 26, 2017
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -http labels May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants