Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More exposition for VN elicitation by padding #4058

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

martinthomson
Copy link
Member

It was not clear to me that the current text was insufficient, but
hopefully this is more sufficient.

Closes #4021.

It was not clear to me that the current text was insufficient, but
hopefully this is more sufficient.

Closes #4021.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Aug 27, 2020
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we really need this...

@martinthomson
Copy link
Member Author

I think enough opinions suggesting that we don't need this might lead me to close the PR over Gorry's objections, but I am sensitive to the fact that most people here are perhaps a little too familiar with the protocol already.

Copy link
Contributor

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text seems to answer my question - Since this in section 6, I'd have also preferred adding a forward reference to the later section 14.1 to get the details.

@martinthomson
Copy link
Member Author

Cross references are cheap.

@janaiyengar janaiyengar merged commit 0e1ab2e into master Aug 27, 2020
@janaiyengar janaiyengar deleted the too-small-no-vn branch August 27, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client that does not PAD does not negotiate?
5 participants