Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magnus' TLS nits #4205

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Magnus' TLS nits #4205

merged 4 commits into from
Oct 15, 2020

Conversation

martinthomson
Copy link
Member

These are all small, but neat improvements inspired by the feedback in #4204.

Closes #4204.

@martinthomson
Describe TLS properties more precisely
0e46958
@martinthomson
Just describe 0-RTT (and its limitations)
2ab6335
@martinthomson
DCID is 0..20 and clarify...
baeefed 
... that after Retry the use of the new Destination Connection ID does
not provide address validation (this was previously obtusely stated).

Note that this critically says that a Destination Connection ID of any
length is not sufficient to prove that the server got the packet.
This is because the client doesn't know how hard the value is to guess,
even if the value is 8 byte or more long and might appear to contain
sufficient entropy (it could be a deterministic function of the client
address, for example).
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -tls labels Oct 14, 2020
seanturner
seanturner approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@seanturner seanturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that we dropped the MUST NOT, it's already somewhere else. I also like that we point back to quic-trans for the dcid info.

@larseggert larseggert mentioned this pull request Oct 15, 2020
Closed
janaiyengar
janaiyengar approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

draft-ietf-quic-tls.md Outdated Show resolved Hide resolved
@martinthomson @janaiyengar
so...
9811e96 
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@martinthomson martinthomson merged commit 9d1a641 into master Oct 15, 2020
@martinthomson martinthomson deleted the tls-magnus-nits branch October 15, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

@gloinul gloinul gloinul approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

@seanturner seanturner seanturner approved these changes

Assignees
No one assigned
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS-31: Minor editorial issues
5 participants
@martinthomson @seanturner @janaiyengar @gloinul @ianswett