Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't refer to the Time Threshold Loss Detection Timer #4222

Merged
merged 5 commits into from
Oct 20, 2020

Conversation

ianswett
Copy link
Contributor

That term doesn't appear above, so don't use it in the PTO section.

Fixes #4193

That term doesn't appear above, so don't use it in the PTO section.

Fixes #4193
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial suggestion. I'm fine with merging this, but @gloinul should probably see if it addresses his issue.

draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@ianswett ianswett added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Oct 15, 2020
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second suggestion is a little risky, but avoids a slightly awkward construction.

draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
draft-ietf-quic-recovery.md Outdated Show resolved Hide resolved
ianswett and others added 3 commits October 16, 2020 14:25
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
@ianswett
Copy link
Contributor Author

Thanks @martinthomson I took your suggestions with one tweak.

@ianswett ianswett merged commit 7c59397 into master Oct 20, 2020
@ianswett ianswett deleted the ianswett-no-loss-detection-timer branch October 20, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recovery-31: PTO time MUST NOT be set and interaction with time threshold
4 participants