Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GREASE the server port number #424

Merged
merged 1 commit into from
May 3, 2017
Merged

GREASE the server port number #424

merged 1 commit into from
May 3, 2017

Conversation

bemasc
Copy link
Contributor

@bemasc bemasc commented Mar 30, 2017

No description provided.

@bemasc bemasc mentioned this pull request Apr 7, 2017
@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -http labels Apr 12, 2017
@@ -105,6 +105,11 @@ Connectivity problems (e.g. firewall blocking UDP) can result in QUIC connection
establishment failure, in which case the client SHOULD continue using the
existing connection or try another alternative endpoint offered by the origin.

Servers MAY serve HTTP/QUIC on any UDP port. Servers MUST use the same port
across all IP addresses that serve a single domain, and SHOULD NOT change this
port. Servers SHOULD choose this port at random when first enabling HTTP/QUIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion from the editors: It's perfectly reasonable to point out that hq can be on any port and that's supported. The "SHOULD randomize" gets into the middlebox debate and really should become a separate issue if we're going to recommend it. (And it could legitimately become a best practice whether the spec recommends it or not.)

If you back this piece out (or I can do it), I think the rest is fine to merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I just remove it, or switch to MAY?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove it -- if it's just a MAY, then it's duplicative of "MAY serve ... on any UDP port."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants