Martin Duke's nits #4449
Merged
Martin Duke's nits #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an odd case, but it is important to identify because it can lead to pretty bad failures. Hopefully Retry integrity has made this unnecessary.
ianswett
approved these changes
Dec 22, 2020
This was
linked to
issues
Dec 22, 2020
This was
linked to
issues
Dec 22, 2020
martinduke
approved these changes
Dec 22, 2020
janaiyengar
approved these changes
Dec 22, 2020
Co-authored-by: ianswett <ianswett@users.noreply.github.com>
|
I realized that there are some answers here in the description, but probably best to move them to the relevant issues anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address all of them at once; one per commit for those that I think need action.
This is probably OK:
This is not expressly forbidden. We do say this:
Which doesn't really contradict the other. FWIW, I'm not a fan of allowing frames to be copied, implementations really should do that, but it's a consequence of having frame idempotency.
This is one I'm not sure about:
What is the prevailing advice regarding MTU and tunnels? Clearly when you tunnel you get a smaller MTU, but I haven't seen what happens when IPv6 is tunneled over a network that has a minimum MTU. Most paths don't have that small an MTU, so it might be that things just fail.