Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword unpadded PATH_CHALLENGE language #4580

Merged
merged 4 commits into from
Jan 7, 2021
Merged

Conversation

martinthomson
Copy link
Member

This was definitely odd. Let's take another tilt at making it
comprehensible.

Closes #4513.

This was definitely odd.  Let's take another tilt at making it
comprehensible.

Closes #4513.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 6, 2021
Comment on lines 2304 to 2305
A PATH_CHALLENGE frame that was sent in a datagram that was not expanded to at
least 1200 bytes validates the peer address, but it does not validate the path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A PATH_CHALLENGE frame that was sent in a datagram that was not expanded to at
least 1200 bytes validates the peer address, but it does not validate the path
A PATH_CHALLENGE frame sent in a datagram that was not expanded to at
least 1200 bytes validates the peer address, but it does not validate the path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I'll tweak further.

Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>
@martinthomson martinthomson merged commit 7c99fe2 into master Jan 7, 2021
@martinthomson martinthomson deleted the only-address-valid branch January 7, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erik Kline's Transport Comment 1
4 participants