The transport parameter removes EOED #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As agreed via mail. Closes #4475.
martinthomson
added
design
marten-seemann
approved these changes
Jan 7, 2021
janaiyengar
approved these changes
Jan 7, 2021
nibanks
approved these changes
Jan 7, 2021
seanturner
approved these changes
Jan 8, 2021
DavidSchinazi
approved these changes
Jan 13, 2021
ianswett
approved these changes
Jan 13, 2021
kaduk
approved these changes
Jan 13, 2021
| @@ -1821,6 +1821,9 @@ QUIC (such as the use of TLS with TCP defined in {{!TLS13}}). A fatal | |||
| unsupported_extension alert MUST be sent by an implementation that supports this | |||
| extension if the extension is received when the transport is not QUIC. | |||
|
|
|||
| Negotiating the quic_transport_parameters extension causes the EndOfEarlyData to | |||
There was a problem hiding this comment.
Suggested change
| Negotiating the quic_transport_parameters extension causes the EndOfEarlyData to | |
| Negotiating the quic_transport_parameters extension causes the requirement to send EndOfEarlyData to |
There was a problem hiding this comment.
I think that the shorter phrasing is better. It's not about not having a requirement to send EOED, but a requirement to not send EOED. And, as this refers to the very next section, the fewer words expended here the better.
There was a problem hiding this comment.
For the question is whether an implementer (bot being on mind you) would be confused by the lack of "requirement to send" phrase, I tend to think that without it's still clear that you don't send EOED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed via mail.
Closes #4475.