Spin bit: Not implemented == disabled #4691
Conversation
draft-ietf-quic-transport.md
Outdated
| @@ -5113,6 +5113,8 @@ discussed in {{?QUIC-MANAGEABILITY=I-D.ietf-quic-manageability}}. | |||
|
|
|||
| The spin bit is an OPTIONAL feature of this version of QUIC. A QUIC stack that | |||
| chooses to support the spin bit MUST implement it as specified in this section. | |||
| A QUIC stack that chooses not to support the spin bit MUST behave as if it were | |||
There was a problem hiding this comment.
Do we need to add this sentence?
There was a problem hiding this comment.
I have a simpler change:
The spin bit is an OPTIONAL feature of this version of QUIC. An endpoint that does not support this feature MUST disable it, as defined below.
There was a problem hiding this comment.
Use of "QUIC stack" is also odd. I like @martinthomson 's simpler suggestion.
draft-ietf-quic-transport.md
Outdated
| @@ -5126,7 +5128,9 @@ approximately one in eight network paths. | |||
| When the spin bit is disabled, endpoints MAY set the spin bit to any value, and | |||
| MUST ignore any incoming value. It is RECOMMENDED that endpoints set the spin | |||
| bit to a random value either chosen independently for each packet or chosen | |||
| independently for each connection ID. | |||
| independently for each connection ID. One way to accomplish this is to adjust | |||
There was a problem hiding this comment.
This seems like a useful addition.
There was a problem hiding this comment.
No. No. No. This does not work. We discussed this. It breaks the AEAD.
draft-ietf-quic-transport.md
Outdated
| @@ -5113,6 +5113,8 @@ discussed in {{?QUIC-MANAGEABILITY=I-D.ietf-quic-manageability}}. | |||
|
|
|||
| The spin bit is an OPTIONAL feature of this version of QUIC. A QUIC stack that | |||
| chooses to support the spin bit MUST implement it as specified in this section. | |||
| A QUIC stack that chooses not to support the spin bit MUST behave as if it were | |||
There was a problem hiding this comment.
I have a simpler change:
The spin bit is an OPTIONAL feature of this version of QUIC. An endpoint that does not support this feature MUST disable it, as defined below.
draft-ietf-quic-transport.md
Outdated
| @@ -5126,7 +5128,9 @@ approximately one in eight network paths. | |||
| When the spin bit is disabled, endpoints MAY set the spin bit to any value, and | |||
| MUST ignore any incoming value. It is RECOMMENDED that endpoints set the spin | |||
| bit to a random value either chosen independently for each packet or chosen | |||
| independently for each connection ID. | |||
| independently for each connection ID. One way to accomplish this is to adjust | |||
There was a problem hiding this comment.
No. No. No. This does not work. We discussed this. It breaks the AEAD.
martinthomson
dismissed
their stale review
I've hijacked the PR with my preferred outcome
Fixes #4666.