Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various version negotiation fixes #474

Merged
merged 2 commits into from
May 3, 2017
Merged

Various version negotiation fixes #474

merged 2 commits into from
May 3, 2017

Conversation

martinthomson
Copy link
Member

@martinthomson martinthomson commented Apr 27, 2017 •
edited
Loading

  1. Version negotiation is stateless (this was implied but not made explicit)

  2. Client ignores version negotiation packets if it has already done version negotiation.

  3. Client ignores version negotiation packets if they list the version it is using.

Closes #284, #294, #241, #143.

@martinthomson
Various version negotiation fixes
6117221 
1. Version negotiation is stateless (this was implied but not made explicit)

2. Client ignores version negotiation packets if it has already done version
   negotiation.

3. Client ignores version negotaition packets if they list the version it is
   using.

Closes #284, #294, #241.
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Apr 27, 2017
@marten-seemann marten-seemann mentioned this pull request Apr 27, 2017
Closed
@martinthomson martinthomson removed this from the First Implementation Draft milestone Apr 28, 2017
@martinthomson
Copy link
Member Author

This is trivial, but closes a bunch of first implementation draft issues. @janaiyengar, I'd like to merge this before 2017-05-02.

janaiyengar
janaiyengar reviewed May 3, 2017
View reviewed changes
draft-ietf-quic-transport.md Outdated
Version Negotiation packet.

A client MUST ignore a Version Negotiation packet if it lists the version it has
chosen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is difficult to parse. How about "A client MUST ignore a Version Negotiation packet that lists the client's chosen version."

janaiyengar
janaiyengar approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but LGTM

@martinthomson martinthomson merged commit ca81361 into master May 3, 2017
@martinthomson martinthomson deleted the verneg_fixes branch May 3, 2017 01:16
This was referenced May 4, 2017
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaiyengar janaiyengar janaiyengar approved these changes

Assignees

@janaiyengar janaiyengar

Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinthomson @janaiyengar