Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the fixed bit recommendation for Version Negotiation #4744

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Explain the fixed bit recommendation for Version Negotiation #4744

merged 3 commits into from
Jan 15, 2021

Conversation

martinthomson
Copy link
Member

Closes #4468.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 14, 2021
@martinthomson
Set to an arbitrary value
827cd37
@martinthomson
This is not reliable
4ab59bf 
Other versions of QUIC might not make the same recommendation.
@martinthomson martinthomson merged commit d7a2e16 into master Jan 15, 2021
@martinthomson martinthomson deleted the why-fixed-vn branch January 15, 2021 03:06
janaiyengar
janaiyengar reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but LGTM

@gloinul gloinul mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaiyengar janaiyengar janaiyengar left review comments

@ianswett ianswett ianswett approved these changes

@DavidSchinazi DavidSchinazi DavidSchinazi approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robert Wilton Invariants Discuss 1
4 participants
@martinthomson @DavidSchinazi @janaiyengar @ianswett