-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix confusing indexing name #4933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these changes are correct. The point of the absolute index is that it's not changing -- these are the definitions of how other types of references map to an absolute index, and which absolute indices can be expressed by each reference type.
How about this? should make sense more |
The opening text for each representation is trying to state which dynamic table entries are eligible for for that representation. All three representations state that they include either a relative or post-base index in the paragraph following the diagram. The eligibility condition is awkward because "Base" really means "Base Insert Count". Comparing indexes and counts can get confusing - eg: Absolute Index = 0 can be used in Indexed Field Line when Base (count) is 1 or greater. So the explanation in the draft works better for me than the proposed text, but I don't love it. I'm inclined not to merge this PR. |
Hmm, I don't come up with any other representation. |
1024 is a blank line, so I'm guessing you meant a different line number. 1043, maybe? I think the confusion is that they're not describing the same thing with opposite adjectives; they're describing related but different concepts.
So every entry has an absolute index, but no instructions use absolute indices. Instead, they use relative indices. A decoder will first resolve a relative index into an absolute index, then look up that location in the table. |
Maybe I get the point (Yes, line 1043 is correct) |
Right -- the absolute index is a concept used to describe how things work, but is never used directly on the wire. |
absolute index
could make sense, butIndexed Field Line
andLiteral Field Line With Name Reference
are better to userelative index
, because these are said asrelative index
when T=0 at line 1043 and 1098.post base index
as well. it would be better thanabsolute index
.Line 585 said this index as
Unlike in encoder instructions, relative indices in field line representations are relative to the Base at the beginning of the encoded field section