Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify unknown unidirectional stream handling #4942

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

MikeBishop
Copy link
Contributor

Fixes #4929.

Copy link
Member

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@LPardue LPardue added -http design An issue that affects the design of the protocol; resolution requires consensus. labels Nov 2, 2021
@@ -1771,7 +1772,7 @@ managing these extension points: frame types ({{iana-frames}}), settings
({{iana-stream-types}}).

Implementations MUST ignore unknown or unsupported values in all extensible
protocol elements. Implementations MUST discard frames and abort reading on
protocol elements. Implementations MUST discard data and/or abort reading on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and/or" is a bad smell. the colloquial "or" is sufficient here.

@MikeBishop MikeBishop changed the base branch from main to h3qp_auth48 February 14, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disagreement in handling of unknown unidirectional stream types
5 participants