Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify handshake packets #535

Merged
merged 2 commits into from
May 17, 2017
Merged

Clarify handshake packets #535

merged 2 commits into from
May 17, 2017

Conversation

ianswett
Copy link
Contributor

Intended to fix Issue #526

Intended to fix Issue #526.
@ianswett ianswett requested a review from janaiyengar May 17, 2017 16:36
@@ -196,7 +196,8 @@ An unacknowledged QUIC packet is marked as lost in one of the following ways:
lost when a packet larger than it is acknowledged and a threshold amount of
time has passed since the packet was sent.

* Handshake packets are special in a number of ways, and a separate alarm
* Handshake packets, which contain stream frames for stream 0, are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stream -> STREAM

Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny nit.

@ianswett ianswett merged commit 93467b4 into master May 17, 2017
@martinthomson martinthomson deleted the ianswett-patch-1 branch May 22, 2017 04:25
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants