Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified how to specify missing packets #647

Closed
wants to merge 1 commit into from

Conversation

ianswett
Copy link
Contributor

Added a sentence to the ack frame in an effort to close #613

@martinthomson martinthomson added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. -transport design An issue that affects the design of the protocol; resolution requires consensus. and removed -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jun 21, 2017
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a grossly inefficient encoding, but at the point where you have a 255 packet gap, efficiency is probably out the window anyway.

Don't we also have to say that the gap can be 0 also?

@mnot mnot removed the design An issue that affects the design of the protocol; resolution requires consensus. label Sep 25, 2017
@ianswett ianswett closed this Oct 2, 2017
@martinthomson martinthomson deleted the ianswett-clarify-missing branch October 12, 2017 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAP limitation in ACK Frame
3 participants