Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A STREAM frame MUST NOT be empty #657

Merged
merged 1 commit into from
Jun 25, 2017
Merged

A STREAM frame MUST NOT be empty #657

merged 1 commit into from
Jun 25, 2017

Conversation

martinthomson
Copy link
Member

Closes #652.

@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jun 23, 2017
ianswett
ianswett approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but the two texts read identically to me. Is there a reason for the change?

@martinthomson
Copy link
Member Author

@ianswett, see the referenced issue. I had no issue with the original text, but Mike's text seemed like a (minor) improvement.

@ianswett
Copy link
Contributor

Agreed, it's a minor improvement, I just wanted to ensure I wasn't missing something.

@martinthomson martinthomson merged commit 400a607 into master Jun 25, 2017
@martinthomson martinthomson deleted the stream_not_empty branch June 25, 2017 22:27
@MikeBishop
Copy link
Contributor

The previous wording implied, contrary to what i think we all meant, that non-zero length and FIN on the same data frame was an invalid combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinthomson @ianswett @MikeBishop