Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that it is cleartext packets that have an FNV hash #683

Merged
merged 2 commits into from
Jul 20, 2017

Conversation

martinthomson
Copy link
Member

At the hackathon it came out that several people believed that Version Negotiation had integrity protection. This was understandable. The transport doc only said that integrity was for cleartext and said nothing about version neogitation, which isn't great. What was worse was that the TLS doc said that it was for all unprotected packets, which is not the case.

@martinthomson martinthomson added -tls editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jul 15, 2017

Unprotected packets all use the long form of the QUIC header and so will include
a version number. For this version of QUIC, the integrity check uses the 64-bit
QUIC adds an integrity check to all cleartext packets. Cleartext packetare not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: packetare

protected by the negotiated AEAD (see {{packet-protection}}), but instead
include an integrity check. This check does not prevent the packet from being
altered, it exists for added resilience against data corruption and to provided
added assurance that the sender intends to use QUIC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provided?

@martinthomson martinthomson merged commit 607ba92 into master Jul 20, 2017
@martinthomson martinthomson deleted the vn_fnv branch July 20, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants