Express MAX_DATA in octets rather than KB #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft-ietf-quic-transport.md
Outdated
| sent on the entire connection, in units of 1024 octets. That is, the updated | ||
| connection-level data limit is determined by multiplying the encoded value by | ||
| 1024. | ||
| sent on the entire connection, in units octets. |
There was a problem hiding this comment.
imagine how many mistakes I can make in a diff more than 1 line long.
|
wohoo |
janaiyengar
approved these changes
Oct 14, 2017
|
What about initial_max_data in the extension? |
|
are you suggesting it needs to be more than 32 as an initial value? That
sort of stretches the credulity of flow control...
…On Sun, Oct 22, 2017 at 2:54 PM, Subodh Iyengar ***@***.***> wrote:
What about initial_max_data in the extension?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#874 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP5s02pqdP8p3YVkJ5zqfTRBlsy8mNbks5su49ogaJpZM4P4_zj>
.
|
|
no i'm suggesting it doesn't need to have a 1024 multiplier. |
|
+1! Let's just use octets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #873