Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ian's Editorial Nits #95

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Ian's Editorial Nits #95

merged 1 commit into from
Mar 5, 2021

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Feb 5, 2021

Here are some suggestions from my first pass, but overall I think the static vs dynamic server ID allocation idea works nicely.

2 Q's:

  • Is the definition of non-compliant different at LB and server in some cases?
  • Might non-routable be a better term than non-compliant?

Here are some suggestions from my first pass, but overall I think the static vs dynamic server ID allocation idea works nicely.

2 Q's:
- Is the definition of non-compliant different at LB and server in some cases?
- Might non-routable be a better term than non-compliant?
@martinduke martinduke merged commit 710f916 into quicwg:master Mar 5, 2021
@martinduke
Copy link
Contributor

Here are some suggestions from my first pass, but overall I think the static vs dynamic server ID allocation idea works nicely.

Thanks, I merged your suggestions.

2 Q's:

* Is the definition of non-compliant different at LB and server in some cases?

Yes, they can be different because the perception of the configuration is different. In general, during configuration updates the LB will have a configs that some servers don't. Therefore, a DCID with those CR bits will be compliant at the LB and non-compliant at the server.

With static allocation, servers don't do anything with non-compliant DCIDs, so this is irrelevant. With dynamic allocation, it means that the LB will allocate an SID that the server doesn't know anything about, until:

  1. the allocation times out
  2. the LB has the occasion to forward another packet with that SID to the server when the server has the configuration.
* Might non-routable be a better term than non-compliant?

I don't feel strongly about this, but it works for me. If you want to file a PR with this change I'd approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants