Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make triggers behave like mixins #23

Closed
rmarx opened this issue Oct 4, 2019 · 0 comments
Closed

Make triggers behave like mixins #23

rmarx opened this issue Oct 4, 2019 · 0 comments

Comments

@rmarx
Copy link
Contributor

rmarx commented Oct 4, 2019 •
edited
Loading

Since no-one is implementing triggers as top-level fields and it was always unclear how to best approach them, we should punt them to optional properties of the "data" field instead. This allows their flexibility without their overhead.

See also issue #7
@rmarx rmarx closed this as completed in 37bb6b7 Oct 4, 2019
rmarx pushed a commit that referenced this issue Oct 7, 2019
Fix various aspects
327f455 
- Yes, I know, I should be more focused

- Redesigned parameters_set event to be very generic

- Proper packet_dropped definition (fixes #14)

- Added clarity about generic message events

- Added introduction

- Added guidance about events not belonging to a single connection

- Properly defined multiple state updated events

- Added explicit trigger fields to events supporting them (see issue #23)
@rmarx rmarx mentioned this issue Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmarx