Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require specific encoding for string fields #36

Closed
rmarx opened this issue Jan 18, 2020 · 2 comments
Closed

Require specific encoding for string fields #36

rmarx opened this issue Jan 18, 2020 · 2 comments

Comments

@rmarx
Copy link
Contributor

rmarx commented Jan 18, 2020

For example, NewTokenFrame doesn't really need a length field if the encoding of the token is specified (e.g., if it is hex-encoded, byte-length is 2x token.length).

We already indicate hex-encoding at other places in the text (e.g., for version), maybe it's a good idea to enforce this across the board (then also specificy whether it should have 0x prefix or not etc. + examples).

Thanks to @marten-seemann for reporting

@marten-seemann
Copy link
Collaborator

This also applies to the NEW_CONNECTION_ID frame.

@marten-seemann
Copy link
Collaborator

Could this be as easy as saying that all byte-values are hex-encoding (omitting the 0x) somewhere in the introduction? Then this would apply to connection IDs, Retry tokens, NEW_TOKEN tokens, stateless reset tokens, etc.

rmarx pushed a commit that referenced this issue Jul 11, 2020
- Updated examples

- Started to decouple JSON from the main schema and describe mapping

- Removed option to specify time_units (fixed #95)

- Overall (partially) relates to: #10, #36, #39, #89, #102, #30
rmarx pushed a commit that referenced this issue Aug 19, 2020
8594230.

- Partially relates to #10, #36, #39, #89, #102, #30

- TODO: not at all sure about the QPACK data types, need outside input

- Last commit before switching to separate draft02 branch
@rmarx rmarx closed this as completed Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants