Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial generation from CMv2.9 & CMv4.0 XML #43

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

quietvoid
Copy link
Owner

@quietvoid quietvoid commented Aug 25, 2021

Needs more testing.
Only supports L1 and L2 trims.

For some reason L2 values from XML and RPUs are different for Netflix's Sparks.

Samples for L5 or other trims welcome.

@quietvoid
Copy link
Owner Author

quietvoid commented Aug 25, 2021

If anyone wants to test, artifacts will be here: https://github.com/quietvoid/dovi_tool/actions/runs/1169155763
RPU can be generated using dovi_tool generate --xml metadata.xml

@quietvoid
Copy link
Owner Author

quietvoid commented Aug 25, 2021

Most of the time, trim_slope (Gain) is different in the RPU vs the XML. The rest should be accurate.
New test build: https://github.com/quietvoid/dovi_tool/actions/runs/1169155763

@quietvoid quietvoid changed the title Add experimental generation from XML Add experimental generation from CMv2.9 XML Aug 25, 2021
@quietvoid quietvoid force-pushed the xml_source branch 2 times, most recently from af17bbb to 6a29db5 Compare August 26, 2021 04:54
@quietvoid quietvoid changed the title Add experimental generation from CMv2.9 XML Add experimental generation from CMv2.9 & CMv4.0 XML Aug 26, 2021
@quietvoid
Copy link
Owner Author

quietvoid commented Aug 26, 2021

Added CMv4.0 partial support. L1, L2 and L3 metadata are parsed.
I still don't know how L5 works, and L8 requires calculations to regenerate L2 so I don't really plan on supporting it.

L3 metadata might be wrong, not sure since I have nothing to compare against.

Still need to calculate L4 metadata from L1 & scene changes.

Build: https://github.com/quietvoid/dovi_tool/actions/runs/1169155763

@quietvoid
Copy link
Owner Author

Looks like L4 metadata relies on the picture itself (mean & stdev of [maxR, maxG, maxB] for every frame), so it can't be generated from XML.

@quietvoid
Copy link
Owner Author

I understand the concept, just not how the values in the XML correlate with a border offset.

CMv2.9: support for L1, L2, and L6 metadata
CMv4.0: support for L1, L2, L3 and L6 metadata
@quietvoid quietvoid changed the title Add experimental generation from CMv2.9 & CMv4.0 XML Add partial generation from CMv2.9 & CMv4.0 XML Aug 27, 2021
@quietvoid quietvoid merged commit 101c817 into main Aug 27, 2021
@quietvoid quietvoid deleted the xml_source branch September 30, 2021 15:26
@quietvoid quietvoid restored the xml_source branch September 30, 2021 15:26
@quietvoid quietvoid deleted the xml_source branch September 30, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant