Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove qvm-ng #300

Merged
merged 1 commit into from
Oct 14, 2022
Merged

remove qvm-ng #300

merged 1 commit into from
Oct 14, 2022

Conversation

stylewarning
Copy link
Member

Sorry to see it go, but it has not been developed, and it is not used in production.

Fixes #299 #296

@ecpeterson
Copy link
Contributor

I'm also sorry to see it go, but it is what it is.

Do the tests still pass locally? The runner is still mad about some package renaming in CL-QUIL.

@stylewarning
Copy link
Member Author

No they don't. Some JSON library API-induced bit rot. It's probably fixable tho without too much work.

If you or someone else uses it, I can fix the tests and keep it going.

@ecpeterson
Copy link
Contributor

Oh I meant the tests on the rest of QVM, after the NG deletion is applied — the thing the GitHub test runner is trying & failing to do.

@stylewarning
Copy link
Member Author

Oh yes, they should be, but I'll have to double check.

We need to change test runners desperately so that they're meaningful. :S

Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qvm-ngn't amiright?

R.I.P. CrustyOldDocketFile gone but not forgotten

@notmgsk
Copy link
Member

notmgsk commented Oct 14, 2022

👋🏽 😿

@notmgsk
Copy link
Member

notmgsk commented Oct 14, 2022

never forget QVMaaS.

@appleby
Copy link
Contributor

appleby commented Oct 14, 2022

pqvm ftw

@stylewarning stylewarning merged commit 83ff64d into master Oct 14, 2022
@stylewarning stylewarning deleted the no-ng branch October 14, 2022 15:16
@stylewarning
Copy link
Member Author

pqvm ftw

d(-_-)bvm

@appleby
Copy link
Contributor

appleby commented Oct 14, 2022

pqvm ftw

d(-_-)bvm

p(-_-)qvm

persistent-but-only-in-our-hearts-qvm

Maybe the real treasure was the PERSISTENT-QVMs we made along the way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete app-ng
4 participants