Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbered list splits when removing middle element #793

Closed
ghost opened this issue Jul 13, 2016 · 5 comments
Closed

Numbered list splits when removing middle element #793

ghost opened this issue Jul 13, 2016 · 5 comments

Comments

@ghost
Copy link

ghost commented Jul 13, 2016

If you create a numbered list with 3 different items, then delete the middle item, the top and bottom item both become "1.", instead of "1." and then "2."

Steps for Reproduction

  1. Visit quilljs.com
  2. Empty the example on the home page
  3. Click to make a numbered list
  4. Enter "Element 1" and press return
  5. Enter "Element 2" and press return
  6. Enter "Element 3" and press return
  7. Click at the end of the line of "Element 2" and press backspace until the line has been entirely removed

Expected behavior:
The elements left should be:-

  1. Element 1
  2. Element 3

Actual behavior:
The elements left are:-

  1. Element 1
  2. Element 3

Platforms:
Firefox 47 on OS X Yosemite

Version:
0.20.1

@sachinrekhi
Copy link
Contributor

This is fixed in the upcoming Quill 1.0 release, which you can test here: http://beta.quilljs.com

@jhchen
Copy link
Member

jhchen commented Jul 14, 2016

Yup beta correctly merges the two lists.

@jhchen jhchen closed this as completed Jul 14, 2016
@neandrake
Copy link

I've only been trying out the demo available on the primary landing page, but this doesn't appear to be working correctly when using Backspace to delete middle items. It does work when using Delete. I'm using Firefox 48.0.1 on OSX 10.11.6.

My steps are:

  1. From demo on http://quilljs.com/, remove all content
  2. Add an Ordered list item
  3. Add 3 items to the list
  4. Remove content of item 2 so it is empty
  5. Use Backspace (on mac just "delete"), which should remove content prior to the cursor, or
  6. Use Delete (on macbook, "fn" + "delete"), which should remove after the cursor

@jhchen
Copy link
Member

jhchen commented Sep 7, 2016

@neandrake Looks like there was a regression. Should be fixed now on quilljs.com

@neandrake
Copy link

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants