Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure correct navbar colour on more devices #14

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

fischer-felix
Copy link

@fischer-felix fischer-felix commented Nov 18, 2022

On my phone (LG V30, Android 9), setting the colour of the navbar does not work when done via themes.xml, so I decided to add a way of programmatically doing it in BaseActivity.kt based on what theme is set.

I also decided to use different colours to those currently set (so that they always match the bottom bar on the overview screen), since that is what you would be looking at the most (when taking a note the keyboard is in use anyway).
The different colour schemes also seem a bit random to me, with a ton of different colours in different places, so maybe this could use some work as well.

Solves #15

@jsixface
Copy link
Collaborator

Can you please create an issue for this with the screenshots attached.

@jsixface
Copy link
Collaborator

Did you find out why the navigation bar color was not set properly by the themes.xml. Is there a way to fix it there ?

@fischer-felix
Copy link
Author

So far, sadly no.
I did see a thread on StackOverflow where someone mentioned, that manufacturers can block certain aspects of the apps theming in their skins.
I also have this problem in a lot of other apps, for example Bitwarden, Moodle and most of the proprietary apps. The ones that do work are Nextcloud, OctoApp, Slide for Reddit and Tasks.org.
I did check the source code of these and it seems they are also setting the color in java/kotlin.

An other option of solving this would be to make the navbar transparent and extending the item above it to fill the space with just it's colour. This would be more work, but would also mean that we wouldn't have to worry about different colours on different screens (e.g. home vs settings vs editor).

@jsixface
Copy link
Collaborator

Can you remote the println() from code ?

@jsixface jsixface merged commit 09a737a into quillpad:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants