ensure correct navbar colour on more devices #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my phone (LG V30, Android 9), setting the colour of the navbar does not work when done via
themes.xml
, so I decided to add a way of programmatically doing it inBaseActivity.kt
based on what theme is set.I also decided to use different colours to those currently set (so that they always match the bottom bar on the overview screen), since that is what you would be looking at the most (when taking a note the keyboard is in use anyway).
The different colour schemes also seem a bit random to me, with a ton of different colours in different places, so maybe this could use some work as well.
Solves #15