Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show database and catalogName #4123

Merged
merged 9 commits into from
Sep 2, 2024
Merged

Show database and catalogName #4123

merged 9 commits into from
Sep 2, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 30, 2024

  • Simplified catalogName/database selector
  • catalogName is always visible alongside database

Before:
image

After:
image

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 38.41%. Comparing base (9705683) to head (72b4e1d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../app/containers/Bucket/Queries/Athena/Database.tsx 0.00% 31 Missing and 1 partial ⚠️
...p/containers/Bucket/Queries/Athena/QueryEditor.tsx 0.00% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
- Coverage   38.42%   38.41%   -0.02%     
==========================================
  Files         724      724              
  Lines       33274    33285      +11     
  Branches     4899     4896       -3     
==========================================
  Hits        12785    12785              
+ Misses      19865    19347     -518     
- Partials      624     1153     +529     
Flag Coverage Δ
api-python 90.85% <ø> (ø)
catalog 11.43% <0.00%> (-0.01%) ⬇️
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus requested a review from nl0 August 30, 2024 15:53
nl0
nl0 previously approved these changes Sep 2, 2024
catalog/CHANGELOG.md Outdated Show resolved Hide resolved
catalog/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
@fiskus fiskus changed the title Show database and catalogname Show database and catalogName Sep 2, 2024
@fiskus fiskus requested a review from nl0 September 2, 2024 10:22
@fiskus fiskus added this pull request to the merge queue Sep 2, 2024
Merged via the queue into master with commit 87471a1 Sep 2, 2024
36 of 38 checks passed
@fiskus fiskus deleted the show-database-and-catalogname branch September 2, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants