Fix selection notify on wrong target #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.
On my previous change I accidentally made the selection notify specify the wrong target as the target to notify for the selection.
This causes some applications to hang looping requests for the expected target. I'm surprised this didn't cause more issues, but by now I think a lot of x11 frameworks have a high tolerance for inter-client protocol mistakes and manage to recover.
I checked the fix against the example, pasting into brave, as well as built alacritty with the fix and it works there too. The mistake is pretty obvious when you see it, but not easy to spot in the changelist.
My bad, sorry about that!