Treat Union{Bool, Real} as StructTypes.Struct #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `Union{Bool, Real}` has struct type `StructTypes.NumberType`
since `Bool <: Integer`, but when parsing a `Bool` or a `Real` from
json, we want to treat them distinctly, by parsing a `Bool` _or_ a
`Real`. The solution here is to just intercept the `read` call for those
`Union` types and pass it to the `Struct` method.
Closed
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 88.94% 88.95%
=======================================
Files 9 9
Lines 1574 1575 +1
=======================================
+ Hits 1400 1401 +1
Misses 174 174
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
Union{Bool, Real}has struct typeStructTypes.NumberTypesince
Bool <: Integer, but when parsing aBoolor aRealfromjson, we want to treat them distinctly, by parsing a
Boolor aReal. The solution here is to just intercept thereadcall for thoseUniontypes and pass it to theStructmethod.