Initializer inputs #894
Merged
Initializer inputs #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdw
force-pushed
the
local-datasets-initializer-inputs
branch
3 times, most recently
from
2ee6cbc
to
8a2fc9e
Compare
grdw
changed the title
grdw
force-pushed
the
local-datasets-initializer-inputs
branch
2 times, most recently
from
5013ee3
to
7069430
Compare
grdw
force-pushed
the
local-datasets-initializer-inputs
branch
from
7069430
to
5c49a94
Compare
ploh
approved these changes
Jan 12, 2017
|
@grdw I pushed my suggestions for this. Please review, further adapt if necessary and merge. Thx. |
grdw
commented
Jan 12, 2017
|
|
||
| def apply_initializer_inputs(graph = nil) | ||
| unless graph |
There was a problem hiding this comment.
This is a bit of a weird solution to be honest, why cramp everyting in a single method?
There was a problem hiding this comment.
Yeah, it seemed like a cool idea earlier, but now at second glance it looks weird!
grdw
commented
Jan 12, 2017
| init. | ||
| map { |key, val| [Input.fetch(key), val] }. | ||
| sort_by { |input, _| input.priority }. | ||
| reverse |
There was a problem hiding this comment.
I'm a bit of a fan of splitting these things up in several methods like:
def initializer_inputs
decorated_inputs.sort_by { |input, _| input.priority }.reverse
end
private
def decorated_inputs
(area.init || {}).map do |key, val|
[Input.fetch(key), val]
end
end... or something like that.
Rationale: Qernel::Dataset is really only a data container
grdw
force-pushed
the
local-datasets-initializer-inputs
branch
from
d9c7d97
to
02ee402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most basic implementation of the initializer inputs.
Related to: quintel/atlas#81