Stubbed out scan tests for CRUD #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 75.25% 75.25%
=======================================
Files 5 5
Lines 194 194
=======================================
Hits 146 146
Misses 48 48Continue to review full report at Codecov.
|
kdelee
approved these changes
Apr 2, 2018
| @@ -344,6 +344,9 @@ | |||
| QCS_SOURCE_TYPES = ('vcenter', 'network', 'satellite') | |||
| """Types of sources that the quipucords server supports.""" | |||
|
|
|||
| QCS_SCAN_TYPES = ('inspect', 'connect') | |||
| """Types of scans that the quipucords server supports.""" | |||
|
|
|||
| result = scan_add({ | ||
| 'name': scan_name, | ||
| 'sources': config_sources()[0]['name'], | ||
| 'sources': source_name |
| 'source_type': 'network'}]} | ||
|
|
||
| assert expected_result == scan_show_result | ||
|
|
There was a problem hiding this comment.
If you wanted to be exhaustive you could somehow make this do more combinations by parametrizing the test ... but that gets done on API side too so may be redundant. Up to you
camayoc/tests/qcs/cli/test_scans.py
Outdated
| :description: Perform a scan and disable an optional product. | ||
| :steps: Run ``qpc scan start --sources <source> --disable-optional-products | ||
| :steps: | ||
| 1) Run ``qpc scan start --sources <source> --disable-optional-products |
There was a problem hiding this comment.
I thought this module would not have any running scans?
There was a problem hiding this comment.
Copy/paste error. Fixed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.