Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scan_timeout configuration #527

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add support for scan_timeout configuration #527

merged 1 commit into from
Jul 4, 2024

Conversation

ruda
Copy link
Member

@ruda ruda commented Jul 3, 2024

This PR makes possible to configure the timeout for the test waiting for a scan to be available. At first it focus on UI tests.

Here is how to customize timeout for 30 minutes (60*30 = 1800). Set in Camayoc config file:

camayoc:
  scan_timeout: 1800

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (0840606) to head (6e6cef4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files           7        7           
  Lines         679      679           
=======================================
  Hits          531      531           
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruda ruda requested review from a team July 3, 2024 20:19
Copy link
Collaborator

@mirekdlugosz mirekdlugosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@ruda ruda merged commit e654fa0 into main Jul 4, 2024
8 of 9 checks passed
@infinitewarp infinitewarp deleted the rmoura/disco-693 branch July 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants