Empty vault password causes scan to fail with certain versions of ansible

[kdelee]

Specify type:

• Bug

Bug severity (if applicable):

-medium

---

Description:

When installing the latest build on rhel 7, the version of ansible that gets installed cannot deal with empty vault password.

---

Bug Report

Version of rho:

[root@localhost ~]# rho --version
version: 0.0.29
	ansible: 2.4.0.0
	python: 2.7.5 (default, May  3 2017, 07:55:04) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]
[root@localhost ~]# rpm -qa | grep rho
rho-0.0.29-1.el7.noarch

Expected behavior:

I should be able to use an empty vault password OR rho should not allow me to create auths/profiles with an empty vault password

Actual behavior:

Rho allows me to create auths/profiles with an empty vault password, but the scan fails because the version of ansible installed by yum does not support this.

Steps to reproduce:

Do the following on a RHEL 7 machine. Use a blank vault password.

[root@localhost~]# yum install -y https://kojipkgs.fedoraproject.org//packages/rho/0.0.29/1.el7/noarch/rho-0.0.29-1.el7.noarch.rpm
[root@localhost~]# rho auth add --name test --username root --sshkeyfile ~/.ssh/id_rsa
[root@localhost ~]# rho profile add --name test --hosts localhost --auth test
[root@localhost ~]# rho scan --profile test --reportfile out.csv

You should get the following output from the scan and contents of the ping log:

Please enter your rho vault password: 
Connection discovery will be perform with the following auth credentials: test
Note: Any ssh-agent connection setup for a target host will be used as a fallback if it exists.

Attempting connection discovery with auth "test".

All auths are invalid for this profile
  
[root@localhost ~]# cat ~/.local/share/rho/ping_log 

 [WARNING]: Error in vault password prompt (default): Invalid vault password
was provided

ERROR! Invalid vault password was provided

Environment information:

Provide detailed information on the scanning and target systems (if applicable); see example below.

Type	Operating System	OS Version	Python Version	Virtualization
Scanning System	RHEL	7.4	2.7.5	ESXi
Target System	same as scanning system

[kdelee]

This issue also comes up on Fedora 26 latest rpm build

[kdelee]

Does not happen with the fedora 25 latest rpm build, which pulled in ansible 2.3.1.0:

[root@fedora25vm ~]# rho --version
version: 0.0.29
	ansible: 2.3.1.0
	python: 2.7.13 (default, May 10 2017, 20:04:28) 
[GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]