-
Notifications
You must be signed in to change notification settings - Fork 7
Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. #476
Conversation
…v was successfully created. Closes #475.
@chambridge FYI i just tried this out, running a scan that is scanning my localhost as well as a remote machine, and I turned the remote machine off in the middle of the scan, and the scan hung after completing all localhost tasks. I am going to try it without the free strategy and see what happens. If this is just a partial fix for that problem, then I can approve this |
@kdelee I reviewed the logs you provided. I think this PR is a fix for this specific issue, however, I think you have uncovered another issue which seems ansible related as it is essentially not detecting that the host has become unreachable in certain cases and the process can hang. I think it makes sense to merge this PR and open another issue. We may need to try reproducing with ansible directly and opening an issue there if necessary. |
I saw a hang while doing my sonar work. If a host is mid scan running a playbook it can hang forever. The hang appears to be in ansible. |
@chambridge that sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to create an issue on rho like "Ansible bug causes scan to hang if host is lost" and when we have enough info to file a bug in Anisble, we can link to it in our issue
* master: Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479) Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476) Fix addition of certs for wrong when condition. Closes #472. (#474) Present more status during discovery for larger environments. Closes #442. (#467) revert default logging change. Closes #460. (#461) Check for empty vault password. Closes #444. (#457) Highlight potential issues in the console output. Closes #443. (#458) Default verbosity to 1 for improved log data. Closes #441. (#456) Turn off colors in the ansible log. Closes #448. (#455) Fix task that can hang if systemctl paginates Update playbook to use free strategy. Closes #445. (#453) Merge 0.30 version into master branch (#451) # Conflicts: # rho/ansible_utils.py # rho/facts.py # rho/inventory_scan.py # rho/postprocessing.py # rho/scancommand.py # roles/jboss_eap/tasks/main.yml # roles/write/tasks/main.yml # test/test_postprocessing.py
* Merge branch 'master' into dev * master: Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479) Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476) Fix addition of certs for wrong when condition. Closes #472. (#474) Present more status during discovery for larger environments. Closes #442. (#467) revert default logging change. Closes #460. (#461) Check for empty vault password. Closes #444. (#457) Highlight potential issues in the console output. Closes #443. (#458) Default verbosity to 1 for improved log data. Closes #441. (#456) Turn off colors in the ansible log. Closes #448. (#455) Fix task that can hang if systemctl paginates Update playbook to use free strategy. Closes #445. (#453) Merge 0.30 version into master branch (#451) # Conflicts: # rho/ansible_utils.py # rho/facts.py # rho/inventory_scan.py # rho/postprocessing.py # rho/scancommand.py # roles/jboss_eap/tasks/main.yml # roles/write/tasks/main.yml # test/test_postprocessing.py
No description provided.