Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. #476

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

chambridge
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage decreased (-0.1%) to 70.315% when pulling 97a3dcd on issues/475 into d45bc2f on master.

@kdelee
Copy link

kdelee commented Nov 15, 2017

@chambridge FYI i just tried this out, running a scan that is scanning my localhost as well as a remote machine, and I turned the remote machine off in the middle of the scan, and the scan hung after completing all localhost tasks. I am going to try it without the free strategy and see what happens.

If this is just a partial fix for that problem, then I can approve this

@chambridge
Copy link
Author

@kdelee I reviewed the logs you provided. I think this PR is a fix for this specific issue, however, I think you have uncovered another issue which seems ansible related as it is essentially not detecting that the host has become unreachable in certain cases and the process can hang.

I think it makes sense to merge this PR and open another issue. We may need to try reproducing with ansible directly and opening an issue there if necessary.

@kholdaway
Copy link

I saw a hang while doing my sonar work. If a host is mid scan running a playbook it can hang forever. The hang appears to be in ansible.

@kdelee
Copy link

kdelee commented Nov 16, 2017

@chambridge that sounds good to me.

Copy link

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to create an issue on rho like "Ansible bug causes scan to hang if host is lost" and when we have enough info to file a bug in Anisble, we can link to it in our issue

@chambridge chambridge merged commit 6fee6f2 into master Nov 16, 2017
@chambridge chambridge deleted the issues/475 branch November 16, 2017 22:23
chambridge added a commit that referenced this pull request Nov 29, 2017
* master:
  Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479)
  Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476)
  Fix addition of certs for wrong when condition. Closes #472. (#474)
  Present more status during discovery for larger environments. Closes #442. (#467)
  revert default logging change. Closes #460. (#461)
  Check for empty vault password. Closes #444. (#457)
  Highlight potential issues in the console output. Closes #443. (#458)
  Default verbosity to 1 for improved log data. Closes #441. (#456)
  Turn off colors in the ansible log. Closes #448. (#455)
  Fix task that can hang if systemctl paginates
  Update playbook to use free strategy. Closes #445. (#453)
  Merge 0.30 version into master branch (#451)

# Conflicts:
#	rho/ansible_utils.py
#	rho/facts.py
#	rho/inventory_scan.py
#	rho/postprocessing.py
#	rho/scancommand.py
#	roles/jboss_eap/tasks/main.yml
#	roles/write/tasks/main.yml
#	test/test_postprocessing.py
chambridge added a commit that referenced this pull request Nov 29, 2017
* Merge branch 'master' into dev

* master:
  Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479)
  Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476)
  Fix addition of certs for wrong when condition. Closes #472. (#474)
  Present more status during discovery for larger environments. Closes #442. (#467)
  revert default logging change. Closes #460. (#461)
  Check for empty vault password. Closes #444. (#457)
  Highlight potential issues in the console output. Closes #443. (#458)
  Default verbosity to 1 for improved log data. Closes #441. (#456)
  Turn off colors in the ansible log. Closes #448. (#455)
  Fix task that can hang if systemctl paginates
  Update playbook to use free strategy. Closes #445. (#453)
  Merge 0.30 version into master branch (#451)

# Conflicts:
#	rho/ansible_utils.py
#	rho/facts.py
#	rho/inventory_scan.py
#	rho/postprocessing.py
#	rho/scancommand.py
#	roles/jboss_eap/tasks/main.yml
#	roles/write/tasks/main.yml
#	test/test_postprocessing.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants