Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Present more status during discovery for larger environments. Closes #442. #467

Merged
merged 2 commits into from
Nov 13, 2017

Conversation

chambridge
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Nov 13, 2017

Coverage Status

Coverage decreased (-1.05%) to 70.411% when pulling e17686b on issues/442 into fbd4a6d on master.

rho/utilities.py Outdated
if hosts_unreachable > 0:
print(_('%d hosts were unreachable.' % hosts_unreachable))

print('')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you need two line breaks so having a single print line with '\n' as parameter producs two line breaks.

Copy link

@elyezer elyezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a separated comment, feel free to handle if it makes sense.

@coveralls
Copy link

coveralls commented Nov 13, 2017

Coverage Status

Coverage decreased (-1.01%) to 70.447% when pulling 043ccb9 on issues/442 into fbd4a6d on master.

@chambridge chambridge merged commit 7d67baa into master Nov 13, 2017
@chambridge chambridge deleted the issues/442 branch November 13, 2017 17:42
chambridge added a commit that referenced this pull request Nov 29, 2017
* master:
  Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479)
  Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476)
  Fix addition of certs for wrong when condition. Closes #472. (#474)
  Present more status during discovery for larger environments. Closes #442. (#467)
  revert default logging change. Closes #460. (#461)
  Check for empty vault password. Closes #444. (#457)
  Highlight potential issues in the console output. Closes #443. (#458)
  Default verbosity to 1 for improved log data. Closes #441. (#456)
  Turn off colors in the ansible log. Closes #448. (#455)
  Fix task that can hang if systemctl paginates
  Update playbook to use free strategy. Closes #445. (#453)
  Merge 0.30 version into master branch (#451)

# Conflicts:
#	rho/ansible_utils.py
#	rho/facts.py
#	rho/inventory_scan.py
#	rho/postprocessing.py
#	rho/scancommand.py
#	roles/jboss_eap/tasks/main.yml
#	roles/write/tasks/main.yml
#	test/test_postprocessing.py
chambridge added a commit that referenced this pull request Nov 29, 2017
* Merge branch 'master' into dev

* master:
  Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479)
  Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476)
  Fix addition of certs for wrong when condition. Closes #472. (#474)
  Present more status during discovery for larger environments. Closes #442. (#467)
  revert default logging change. Closes #460. (#461)
  Check for empty vault password. Closes #444. (#457)
  Highlight potential issues in the console output. Closes #443. (#458)
  Default verbosity to 1 for improved log data. Closes #441. (#456)
  Turn off colors in the ansible log. Closes #448. (#455)
  Fix task that can hang if systemctl paginates
  Update playbook to use free strategy. Closes #445. (#453)
  Merge 0.30 version into master branch (#451)

# Conflicts:
#	rho/ansible_utils.py
#	rho/facts.py
#	rho/inventory_scan.py
#	rho/postprocessing.py
#	rho/scancommand.py
#	roles/jboss_eap/tasks/main.yml
#	roles/write/tasks/main.yml
#	test/test_postprocessing.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants