This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Check for empty vault password. Closes #444. #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyezer
approved these changes
Nov 9, 2017
rho/vault.py
Outdated
| @@ -23,6 +23,8 @@ | |||
| from rho.translation import _ as t | |||
|
|
|||
| PROMPT = "Please enter your rho vault password: " | |||
| ERROR_PROMPT = 'Error: The vault password cannot be empty. '\ | |||
| 'Please provide a none empty password.' | |||
There was a problem hiding this comment.
I am not sure but I think the message should be "Please provide a non empty password", mind non instead of none?
There was a problem hiding this comment.
yep, I'll fix it. should be non-empty.
| vault_password = '' | ||
| while vault_password == '': | ||
| vault_password = getpass("\033[01;36m" + prompt + "\033[0m") | ||
| if vault_password == '': |
There was a problem hiding this comment.
Doing this validation it would allow one or more spaces as a vault password, is it ok?
There was a problem hiding this comment.
I've verified that spaces are fine as a password.
1 similar comment
chambridge
added a commit
that referenced
this pull request
Nov 29, 2017
* master: Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479) Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476) Fix addition of certs for wrong when condition. Closes #472. (#474) Present more status during discovery for larger environments. Closes #442. (#467) revert default logging change. Closes #460. (#461) Check for empty vault password. Closes #444. (#457) Highlight potential issues in the console output. Closes #443. (#458) Default verbosity to 1 for improved log data. Closes #441. (#456) Turn off colors in the ansible log. Closes #448. (#455) Fix task that can hang if systemctl paginates Update playbook to use free strategy. Closes #445. (#453) Merge 0.30 version into master branch (#451) # Conflicts: # rho/ansible_utils.py # rho/facts.py # rho/inventory_scan.py # rho/postprocessing.py # rho/scancommand.py # roles/jboss_eap/tasks/main.yml # roles/write/tasks/main.yml # test/test_postprocessing.py
chambridge
added a commit
that referenced
this pull request
Nov 29, 2017
* Merge branch 'master' into dev * master: Add jboss.eap.init-files to JBOSS_FACTS. Closes #478. (#479) Add default dictionaries to handle lost host. Handle ansible rc if csv was successfully created. Closes #475. (#476) Fix addition of certs for wrong when condition. Closes #472. (#474) Present more status during discovery for larger environments. Closes #442. (#467) revert default logging change. Closes #460. (#461) Check for empty vault password. Closes #444. (#457) Highlight potential issues in the console output. Closes #443. (#458) Default verbosity to 1 for improved log data. Closes #441. (#456) Turn off colors in the ansible log. Closes #448. (#455) Fix task that can hang if systemctl paginates Update playbook to use free strategy. Closes #445. (#453) Merge 0.30 version into master branch (#451) # Conflicts: # rho/ansible_utils.py # rho/facts.py # rho/inventory_scan.py # rho/postprocessing.py # rho/scancommand.py # roles/jboss_eap/tasks/main.yml # roles/write/tasks/main.yml # test/test_postprocessing.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.