-
Notifications
You must be signed in to change notification settings - Fork 14
Setup local dev for insights-ingress-go. #276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 19 19
Lines 1264 1264
Branches 140 140
=======================================
Hits 1171 1171
Misses 70 70
Partials 23 23 Continue to review full report at Codecov.
|
I ran into the following issue:
but resolved it by following the instructions here. |
Everything worked 🎉and looks good. The only question that I have is if we shoul still refer to ingress as the file upload service everywhere. Do we want to update documentation to say ingress service (since the file-upload service was a thing of the past) or are we okay since it is technically the thing you upload files to? Thoughts @kholdaway @myersCody? |
Great work debugging this issue @abaiken |
I am okay with changing it if we think it is necessary. I think whatever is the least confusing for people on-boarding to the project is the direction we should go with. However, considering that I am relatively new to the project, I may not be the best source to decide which direction we should go in. 🤷♂ |
README.md
Outdated
@@ -267,7 +266,7 @@ make upload-data file=<path/to/your-data.tar.gz> | |||
|
|||
You need to replace `<path/to/your-data.tar.gz>` with either the absolute or relative path to the `tar.gz` file that you want to upload to Insights. | |||
|
|||
After running this command if you see `HTTP 202` like the following lines in your output logs, it means your file upload to Insights was successful: | |||
After running this command if you see `HTTP 202` like the following lines in your output logs, it means your ingress to Insights was successful: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense. it should be upload to the ingress service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🎉
Blocked by: RedHatInsights/insights-ingress-go#112