Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Setup local dev for insights-ingress-go. #276

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Setup local dev for insights-ingress-go. #276

merged 5 commits into from
Nov 13, 2019

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Nov 11, 2019

@myersCody myersCody added the Blocked Blocked by external team so development cannot work on issue label Nov 11, 2019
@myersCody myersCody self-assigned this Nov 11, 2019
@myersCody myersCody changed the title WIP: Setup local dev for insights-ingress-go. Setup local dev for insights-ingress-go. Nov 11, 2019
@myersCody myersCody removed the Blocked Blocked by external team so development cannot work on issue label Nov 11, 2019
Makefile Show resolved Hide resolved
@myersCody myersCody changed the title Setup local dev for insights-ingress-go. WIP: Setup local dev for insights-ingress-go. Nov 12, 2019
@myersCody myersCody changed the title WIP: Setup local dev for insights-ingress-go. Setup local dev for insights-ingress-go. Nov 13, 2019
@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          19       19           
  Lines        1264     1264           
  Branches      140      140           
=======================================
  Hits         1171     1171           
  Misses         70       70           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e988e9...8e21dff. Read the comment docs.

@abaiken
Copy link
Contributor

abaiken commented Nov 13, 2019

I ran into the following issue:

ERROR: Service 'ingress' failed to build: oci runtime error: container_linux.go:265: starting container process caused "exec: \"/bin/sh\": stat /bin/sh: no such file or directory"

but resolved it by following the instructions here.

@abaiken
Copy link
Contributor

abaiken commented Nov 13, 2019

Everything worked 🎉and looks good. The only question that I have is if we shoul still refer to ingress as the file upload service everywhere. Do we want to update documentation to say ingress service (since the file-upload service was a thing of the past) or are we okay since it is technically the thing you upload files to? Thoughts @kholdaway @myersCody?

@myersCody
Copy link
Contributor Author

I ran into the following issue:

ERROR: Service 'ingress' failed to build: oci runtime error: container_linux.go:265: starting container process caused "exec: \"/bin/sh\": stat /bin/sh: no such file or directory"

but resolved it by following the instructions here.

Great work debugging this issue @abaiken

@myersCody
Copy link
Contributor Author

Everything worked 🎉and looks good. The only question that I have is if we shoul still refer to ingress as the file upload service everywhere. Do we want to update documentation to say ingress service (since the file-upload service was a thing of the past) or are we okay since it is technically the thing you upload files to? Thoughts @kholdaway @myersCody?

I am okay with changing it if we think it is necessary. I think whatever is the least confusing for people on-boarding to the project is the direction we should go with. However, considering that I am relatively new to the project, I may not be the best source to decide which direction we should go in.

🤷‍♂

README.md Outdated
@@ -267,7 +266,7 @@ make upload-data file=<path/to/your-data.tar.gz>

You need to replace `<path/to/your-data.tar.gz>` with either the absolute or relative path to the `tar.gz` file that you want to upload to Insights.

After running this command if you see `HTTP 202` like the following lines in your output logs, it means your file upload to Insights was successful:
After running this command if you see `HTTP 202` like the following lines in your output logs, it means your ingress to Insights was successful:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense. it should be upload to the ingress service

Copy link
Contributor

@abaiken abaiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants