Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sveltekit codespaces cron job not working #1121

Closed
JonathonRP opened this issue Feb 15, 2023 · 10 comments · Fixed by #1122 or #1120
Closed

sveltekit codespaces cron job not working #1121

JonathonRP opened this issue Feb 15, 2023 · 10 comments · Fixed by #1122 or #1120

Comments

@JonathonRP
Copy link

Bug Report

Current Behavior
similar to #1089
I have a running in codespaces with a single cron job in sveltekit that shows in status but doesn't show in cron tab
and is not running.

Input Code

Expected behavior/code
cron should be picked up, running and visible in cron tab

Environment

  • Quirrel version: [e.g. v1.13.1]
  • Node/npm version: [e.g. Node 14/npm 6]
  • codespaces
  • sveltekit
@Skn0tt
Copy link
Member

Skn0tt commented Feb 16, 2023

Hi @JonathonRP, thanks for the report! There was a bug where the --host arg wasn't respected everywhere in the codebase. #1122 fixes that, i'll let you know once it's released.

@all-contributors please add @JonathonRP for bug

@allcontributors
Copy link
Contributor

@Skn0tt

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @JonathonRP! 🎉

Skn0tt pushed a commit that referenced this issue Feb 16, 2023
Adds @JonathonRP as a contributor for bug.

This was requested by Skn0tt [in this
comment](#1121 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Skn0tt added a commit that referenced this issue Feb 16, 2023
Skn0tt added a commit that referenced this issue Feb 16, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.13.2](v1.13.1...v1.13.2)
(2023-02-16)


### Bug Fixes

* remove broken tutorial link
([#1119](#1119))
([df0288e](df0288e))
* respect custom host in local dev
([#1122](#1122))
([71304ff](71304ff)),
closes [#1121](#1121)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@Skn0tt
Copy link
Member

Skn0tt commented Feb 16, 2023

https://github.com/quirrel-dev/quirrel/releases/tag/v1.13.2 contains the PR, please let me know if that fixes it for you.

@JonathonRP
Copy link
Author

JonathonRP commented Feb 16, 2023

@Skn0tt, this did not resolve my issue, if it helps here are the errors I get in UI dev console.
image
urls:
image
image

Also note I am using port 5000 for sveltekit app dev server

@Skn0tt
Copy link
Member

Skn0tt commented Feb 22, 2023

Okay, re-opening.

5000 isn't the default sveltekit app dev server, right? If you're changing the port, then you need to tell your app what the new port is. You can do this by setting the env var QUIRREL_BASE_URL=0.0.0.0:5000.

@Skn0tt Skn0tt reopened this Feb 22, 2023
@JonathonRP
Copy link
Author

Thank you @Skn0tt, I tried a few work ways to tell Quirrel port 5000 but never changed the results. also, note that working in my local environment now with no changes, Quirrel works and picks up CronJob.

@Skn0tt
Copy link
Member

Skn0tt commented Feb 28, 2023

Okay, so did this fix your problem, or should I look into it again?

@JonathonRP
Copy link
Author

@Skn0tt please look into it again.

@Skn0tt
Copy link
Member

Skn0tt commented Mar 1, 2023

When running QUIRREL_BASE_URL=http://0.0.0.0:5000 npx quirrel in a codespace with your repo, things are running fine. I noticed it doesn't work with .env, could it be that you've tried that instead? The quirrel CI doesn't pick up your .env automatically, you can take a look at https://www.npmjs.com/package/dotenv-cli if you're looking for that.

@JonathonRP
Copy link
Author

I will give this a try, and it is good enough for me to close this issue now.

@Skn0tt Skn0tt closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants