Added lots of German translations and fixed some small issues here and there #119
Conversation
added German Info-Texts and TTS-Texts (some look a bit weird, but that's adjustment so the German TTS voices pronounce things properly).
Added German and French localization based on the o8s triggers. You might have to look over it, especially the last part with the timeline replacements, since I've simply copied those from o8s and there are lots of useless God Kefka Triggers inside
There was a problem hiding this comment.
This is really great! Hopefully getting github sorted wasn't too much hassle.
I have a few small fix requests if you don't mind making them, mostly just to make this not have javascript errors. You can just make another commit locally in your master branch, push it, and it will show up here.
Did you test this at all locally? (Or do you need pointers on setting cactbot options?)
Finally, I'm sorry that I haven't added any automatic tools yet to show what's missing from timeline translations. In a pinch, you can modify the zoneRegex in o8s.js to be zoneRegex: /Middle La Noscea/, teleport to summerford farms, and then /echo :Kefka:28C2: in game to start the timeline.
ui/raidboss/data/triggers/o8n.js
Outdated
| }, | ||
| { | ||
| id: 'O8N Flagrant Fire Single', | ||
| regex: /1B:........:(\y{Name}):....:....:0017:0000:0000:0000:/, | ||
| regexDe: /1B:........:(\y{Name}):....:....:0017:0000:0000:0000:/, |
There was a problem hiding this comment.
Just FYI, no need for these if they're duplicates. If you specify a language like 'de', then it will use regexDe if it's there, otherwise it will fall back to regex on its own. Would you mind removing all the 1B head marker duplicate lines you added?
There was a problem hiding this comment.
Ah good to know. That was my only worry there, that if I don't specify the regexDe it won't display anything when it's set to de. But if it falls back then I'll cut that back out again :)
ui/raidboss/data/triggers/o8s.js
Outdated
| }, | ||
| }, | ||
| { | ||
| id: "O8S Past's End", | ||
| regex: /Kefka starts using Past's End/, | ||
| regexDe: /Kefka starts using Past's End/, | ||
| regexDe: /Kefka starts using Ende der Welt/, |
There was a problem hiding this comment.
Whoops. Thanks for fixing this. Not sure why none of these translated.
There was a problem hiding this comment.
No problem ^^ I can also translate the rest (fr and jp) while I'm at it so you don't have to do it :)
| }, | ||
| }, | ||
| ], | ||
| timelineReplace: [ |
There was a problem hiding this comment.
I think it's fine to just copy and paste this here. It seems more work than it's worth to separate out what's included and what's not without an automatic tool to do it.
There was a problem hiding this comment.
Yup, I think so, too. Though when it's done you might have to take a look at the function closing brackets if I didn't use one too much or one is missing, since I don't see, which bracket closes what that good. I'll copy it into notepad++ though. Maybe it shows which bracket belongs to which and if there's some overflow of brackets x)
| 'Light Of Consecration': 'Licht[p] Der Weihe', | ||
| 'The Mad Head': 'Verrückt[a] Kopf', | ||
| 'Light Of Consecration': 'Licht Der Weihe', | ||
| 'The Mad Head': 'Verrückter Kopf', |
There was a problem hiding this comment.
Thanks for fixing these up. I wasn't sure what to do with this, because this is what fflogs gave me back.
There was a problem hiding this comment.
Yup, that's a common mistake ff14angler, xivdb and fflogs do, but in the game and in the german logs it's usually the correct expression. I've checked it from my last o8s log :)
ui/raidboss/data/triggers/o8n.js
Outdated
| en: 'Look for Knockback', | ||
| fr: 'Se préparer à la projection', | ||
| de: 'Auf Rückstoß achten', | ||
| },, |
There was a problem hiding this comment.
Can you remove one of these commas?
The thing I always do when submitting triggers is to reload raidboss and make sure that it doesn't have any errors.
There was a problem hiding this comment.
Oh, I didn't see that. Gonna fix it :)
ui/raidboss/data/triggers/o8n.js
Outdated
| }, | ||
| ] |
There was a problem hiding this comment.
You need to add back in this trailing ] here. This is what closes the timelineReplace: [] block.
There was a problem hiding this comment.
Ah, that was a little accident. Gonna put it back in x)
|
Okay I've just edited the mistakes. Also, I've tried to test the changes, but somehow the timeline isn't registering that my game is set to German and still displays the English timeline. Just to reproduce I'll list the steps I took: i. Set the game back to German I've also added the German line for the Timeline-Reset: i. Went to middle LaNoscea And as it turns out the timeline starts and works perfectly - though the timeline-replace doesn't seem to work :/ Also, I've tried setting everything back to normal and entering o8 normal, but there the timeline doesn't start at all, when the game is set to German. |
|
Thanks for the triggers. I'll just go ahead and commit this patch now. More followup can be done in other patches. I haven't figured out how to have cactbot detect your language. I know there's some login message like "Welcome to WORLD!" and "Welcome to FINAL FANTASY XIV" in English. Maybe I could use that to key off of. At any rate, for now you need to add an option for language in cactbot/user/raidboss.js and set One other thing I need German translations for is all of the healer lb3s and the status effects for Weakness and Brink of Death, e.g. https://github.com/quisquous/cactbot/blob/master/CactbotOverlay/WipeDetector.cs#L46 and https://github.com/quisquous/cactbot/blob/master/CactbotOverlay/WipeDetector.cs#L23. |
Also, copy and paste translations from savage to normal modes. cc @ArkfrostLumas @Amiral-Benson This addresses some missing timelines from #119 and #57.
I've added German TTS and Info-Texts to many of the raids, changed the TTS of some German callouts to fit the default Microsoft Hedda Desktop voice for better pronounciation and I've also added the French localization for o8n while I was at it.
There might be some things you have to look over, like o8n at the end, where I've just copy&pasted the timeline translations from o8s, but there're still lots of leftover God Kefka lines which I didn't look up.