Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuixRunner + various changes for 3.8 #197

Merged
merged 15 commits into from
Oct 11, 2023
Merged

Conversation

tim-quix
Copy link
Contributor

@tim-quix tim-quix commented Oct 9, 2023

Many of the changes here are actually to fix various typing issues and thus allow compatibility with Python v3.8

  • Added QuixRunner which automates configuration for running in the Quix Platform

    • edits Topic objects when QuixRunner.run() is called by setting the real_name attribute to the actual Quix topic name, which appends the workspace_id to it.
    • adds all the necessary config values for authenticating to Quix broker.
  • Topic class now has real_name attribute, which defaults to name attribute if not defined.

    • functionality otherwise remains the same for non-quix applications.
    • You are still expected to use the name attribute, QuixRunner handles finding the "real" name
  • RowProducer and RowConsumer now internally reference Topic.real_name, but functionality is equivalent to previous version.

@tim-quix tim-quix changed the base branch from main to feature/sdf October 9, 2023 22:21
Copy link
Collaborator

@daniil-quix daniil-quix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@tim-quix tim-quix merged commit 5bd4477 into feature/sdf Oct 11, 2023
4 checks passed
daniil-quix pushed a commit that referenced this pull request Nov 7, 2023
* all changes for QuixRunner and Python3.8

* change topic dict on dataframe

* move quix runner to the platform folder

* additional changes for 3.8 around dataclasses, tweaked topic_out for dataframe

* missed a couple things

* all changes for QuixRunner and Python3.8

* move quix runner to the platform folder

* additional changes for 3.8 around dataclasses, tweaked topic_out for dataframe

* missed a couple things

* last few touches

* update github workflow for sdf to py38

* missed a spot

* last little cleanups

* removed SlottedClass, last cleanups

* small consistency change
@daniil-quix daniil-quix deleted the feature/quix-runner branch November 14, 2023 17:27
tim-quix pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants