Use .NET 8 for all platforms #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 8 there were some changes to constructor signitures causing a shift - Satisfy the new requirements for delegate when using Marshal.GetFunctionPointerForDelegate
…is not installed at all
|
Some docs probably need updating to let people know this works now? |
I have created an issue to track this. For now the process is the same because using our current azure pipeline this proves to be a bit of headache as apple silicon agents are not readily available. Issue link: #95 |
added 2 commits
April 12, 2023 13:11
peter-quix
approved these changes
Apr 12, 2023
SteveRosam
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make Native AOT compilation work on Apple silicon (ARM) chips, we are upgrading to .net8 as previously this wasn't supported.
Some library packages are still left on version "7.0.0" for stability and no need to update frequently reasons
Tested on:
Macbook Pro M1 (ARM)
Macbook Pro 2015 (Intel) - (build script works but haven't run pytest yet)
Note: Some integration tests are still failing on python, but only few. We should investigate that before merging
Prerequisites for build.py script to work on mac are: