noglobals GET parameter ignored #1
Comments
|
This shouldn't be the case any more - please let me know if it's still a problem, though. |
vivin
added a commit
to vivin/qunit
that referenced
this issue
Aug 16, 2012
Approach qunitjs#1: Raw strings used for assertion type. Also added tests to check for the assertion type.
vivin
added a commit
to vivin/qunit
that referenced
this issue
Aug 16, 2012
Approach qunitjs#1: Forgot to add "expect" to one line where an expect-related failure is reported.
vivin
added a commit
to vivin/qunit
that referenced
this issue
Aug 16, 2012
Approach qunitjs#1: Removing some of the tests.
Krinkle
added a commit
that referenced
this issue
Jun 7, 2021
There were two issues here: * The test relied on non-default maxDepth of null or > 10 since its example involves recurion 10 levels deep, and the default maxDepth is 5. * There is a bug in `QUnit.dump.parse()` where, if the input value cannot be mapped to a formatter function, it returns a function instead of a string. This bug was introduced nearly ten years ago in commit 818b2be, where `error` was replaced with a function that had a different purpose than what was there before, and this one use of it as fallback was not updated. Unfortunately, I am unable to say what value causes this to happen. I can consistently reproduce the issue in Safari 9.1 via BrowserStack, but only if I don't open the console, don't run a subset of the test, and don't modify any of the surrounding code. I have tried dozens upon dozens of clever ways to store values during the parse() function call in temporary variables and alert() them but as soon as I tried to capture anything that would help, the bug would stop happening. I can only conclude that there must be some kind of memory or JIT corruption in the JavaScript engine of Safari 9.1 that has some extremely specific conditions attached to it. Conditions that we did not meet before the last few commits, and are meeting now. ``` [OS X El Capitan, Safari 9.1] Error: "Circular reference with arrays" failed Died on test #1 @http://localhost:8899/test/main/dump.js:279:11: expected.indexOf is not a function. (In 'expected.indexOf("[object Array]")', 'expected.indexOf' is undefined) ```
Krinkle
added a commit
that referenced
this issue
Jun 7, 2021
There were two issues here: * The test relied on non-default maxDepth of null or > 10 since its example involves recurion 10 levels deep, and the default maxDepth is 5. * There is a bug in `QUnit.dump.parse()` where, if the input value cannot be mapped to a formatter function, it returns a function instead of a string. This bug was introduced nearly ten years ago in commit 818b2be, where `error` was replaced with a function that had a different purpose than what was there before, and this one use of it as fallback was not updated. Unfortunately, I am unable to say what value causes this to happen. I can consistently reproduce the issue in Safari 9.1 via BrowserStack, but only if I don't open the console, don't run a subset of the test, and don't modify any of the surrounding code. I have tried dozens upon dozens of clever ways to store values during the parse() function call in temporary variables and alert() them but as soon as I tried to capture anything that would help, the bug would stop happening. I can only conclude that there must be some kind of memory or JIT corruption in the JavaScript engine of Safari 9.1 that has some extremely specific conditions attached to it. Conditions that we did not meet before the last few commits, and are meeting now. ``` [OS X El Capitan, Safari 9.1] Error: "Circular reference with arrays" failed Died on test #1 @http://localhost:8899/test/main/dump.js:279:11: expected.indexOf is not a function. (In 'expected.indexOf("[object Array]")', 'expected.indexOf' is undefined) ```
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QUnit.init overrides the config var, resetting the
noglobalsconfig to false. Since the noglobals get parameter is read before QUnit.init, the noglobals parameter is ignored.The text was updated successfully, but these errors were encountered: