Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiny-glob to 0.2.8 #1522

Closed
3 tasks done
Krinkle opened this issue Nov 29, 2020 · 1 comment
Closed
3 tasks done

Update tiny-glob to 0.2.8 #1522

Krinkle opened this issue Nov 29, 2020 · 1 comment
Assignees
Labels
Category: Release Type: Enhancement New idea or feature request.

Comments

@Krinkle
Copy link
Member

Krinkle commented Nov 29, 2020

Update tiny-glob from 0.2.6 to 0.2.8 (latest).

https://github.com/terkelg/tiny-glob/commits/master

  • Verify npm publisher.
  • Review package diffs.
  • Stage update in PR and confirm releated features: CLI input globbing.
@Krinkle Krinkle added Type: Enhancement New idea or feature request. Category: Release labels Nov 29, 2020
@Krinkle Krinkle self-assigned this Nov 29, 2020
@Krinkle
Copy link
Member Author

Krinkle commented Nov 30, 2020

Verify publication: tiny-glob 0.2.6 -> 0.2.8

$ npm info tiny-glob@0.2.8

dependencies:
- globalyzer: 0.1.0
- globrex: ^0.1.2  

maintainers:
- terkelg <terkel@terkel.com>

published a week ago by terkelg <terkel@terkel.com>

✅ It was published by the same account as previously.
✅ No new maintainers were added.
✅ No new dependencies were added.
⚠️ Some dependency versions changed:

-        "globalyzer": "^0.1.0" -> 0.1.4
+        "globalyzer": "0.1.0" -> 0.1.0
-        "globrex": "^0.1.1" -> 0.1.1
+        "globrex": "^0.1.2" -> 0.1.2

Verify publication: globalyzer 0.1.4 -> 0.1.0 (downgrade)

$ npm info globalyzer@0.1.0

globalyzer@0.1.0

maintainers:
- terkelg <terkel@terkel.com>

published over a year ago by terkelg <terkel@terkel.com>

✅ It was published by the same account as previously.
✅ No new maintainers were added.
✅ No new dependencies were added.
✅ No dependency versions changed.

Verify publication: globrex 0.1.1 -> 0.1.2

globrex@0.1.2 

maintainers:
- terkelg <terkel@terkel.com>

published a year ago by terkelg <terkel@terkel.com>

✅ It was published by the same account as previously.
✅ No new maintainers were added.
✅ No new dependencies were added.
✅ No dependency versions changed.

Review package diff: globalyzer 0.1.4 -> 0.1.0 (downgrade)

https://diff.intrinsic.com/globalyzer/0.1.0/0.1.4 (inverse!)

  • Effectively reverts away use of path.normalize(), and going back to using os.platform(). Upstream mentions that this change caused an issue in their tests, although we didn't run into it, and thus reverts for now. Ref terkelg/tiny-glob@7e61029

LGTM.

Review package diff: globrex 0.1.1 -> 0.1.2

https://diff.intrinsic.com/globrex/0.1.1/0.1.2

  • No code was added or changed.

Review package diff: tiny-glob 0.2.6 -> 0.2.8

https://diff.intrinsic.com/tiny-glob/0.2.6/0.2.8

  • Minor style changes.
  • Added TypeScript declaration file.
  • Changes to internal logic.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Release Type: Enhancement New idea or feature request.
Development

No branches or pull requests

1 participant