Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Move non-bin files from bin/ to src/cli/ #1344

Merged
merged 1 commit into from
Dec 27, 2018
Merged

CLI: Move non-bin files from bin/ to src/cli/ #1344

merged 1 commit into from
Dec 27, 2018

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Dec 27, 2018

Follows-up #1271.

trentmwillis
trentmwillis approved these changes Dec 27, 2018
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@trentmwillis trentmwillis merged commit ca9ce37 into master Dec 27, 2018
@trentmwillis trentmwillis deleted the src-cli branch December 27, 2018 13:32
@rwjblue rwjblue mentioned this pull request Jan 7, 2019
Closed
@rwjblue
Copy link
Contributor

rwjblue commented Jan 7, 2019

This forgot to update the files array in package.json, bin/ was listed but src/ is not. This results in failures in published builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmwillis trentmwillis trentmwillis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krinkle @rwjblue @trentmwillis