Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporter: fix several WCAG violations #1528

Merged
merged 4 commits into from
Dec 28, 2020
Merged

Reporter: fix several WCAG violations #1528

merged 4 commits into from
Dec 28, 2020

Conversation

smcclure15
Copy link
Member

Resolves some of the more straightforward violations (1, 2, and 3) captured in #1427

leobalter
leobalter reviewed Dec 9, 2020
View reviewed changes
reporter/html.js Outdated Show resolved Hide resolved
Krinkle
Krinkle requested changes Dec 10, 2020
View reviewed changes
reporter/html.js Outdated Show resolved Hide resolved
Krinkle
Krinkle reviewed Dec 10, 2020
View reviewed changes
runner/fixture.js Outdated Show resolved Hide resolved
Krinkle
Krinkle requested changes Dec 17, 2020
View reviewed changes
Copy link
Member

@Krinkle Krinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixture attribute is likely breaking. Let's continue the conversation on that and land the rest.

@smcclure15
Copy link
Member Author

This change has reduced to simply adding a main role to the "qunit" div and a navigation role to the toolbar to avoid potential incompatibilities.

@smcclure15 smcclure15 mentioned this pull request Dec 28, 2020
Merged
@Krinkle Krinkle merged commit 8e1c2e2 into qunitjs:master Dec 28, 2020
Krinkle pushed a commit that referenced this pull request Dec 28, 2020
@smcclure15 @Krinkle
HTML Reporter: set main and navigation ARIA roles
7564ec1 
Fixes several WCAG violations (#1528).

Ref #1427.
Closes #1528.
@smcclure15 smcclure15 deleted the htmlreporter-wcag-fixes branch December 28, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobalter leobalter leobalter left review comments

@Krinkle Krinkle Krinkle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smcclure15 @Krinkle @leobalter