HTML Reporter: Increase contrast and use richer colors overall #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New CSS looks reasonable, and I like the look of the newly styled report! |
smcclure15
approved these changes
Apr 14, 2021
Tweak our colors away from the semi-greyish colors we had before, toward more dark/saturated or bright colors. Also reduce the overall number of distinct colors, reusing the same ones more often. * Change most uses of black (`#000000`) to `#0D3349`, which is the very dark blue we already used for the `#qunit-header` background. * Change text in `#qunit .pass` from `#528CE0` to `#2F68DA`, this is more saturated and appears darker. I also moved its hue slightly from cyan-blue, more toward blue-violet. * Change the text color for `#qunit-testresult` from `#3B81AF` to the same dark blue as used for module names, `#366097`. The color previously used here was a medium blue that we didn't use for any other text. * Change the Rerun link from the near-invisible `#C2CCD1` to instead inherit the text color of `#qunit .pass` or `#qunit .fail`, e.g. `#2F68DA`. Also, to make it still stand out as special, add an underline. It retains its liberal padding for easy clickability. Clean up: * Remove unused color value for `#qunit-header`. Instead set it to that of `#qunit-header a` (it only contains a link), and let the latter inherit this color. * Replace redundant `#qunit-tests .fail .test-name` and and `#qunit-tests .fail .module-name ` styles. Ref qunitjs#1427.
|
@smcclure15 Yeah, it gets us closer to Axe compliance. I carved this commit out from an experimental branch I have in my fork with some ideas for a bigger redesign: https://github.com/Krinkle/qunit/commits/qunit3-theme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak our colors away from the semi-greyish colors we had before,
toward more dark/saturated or bright colors.
Also reduce the overall number of distinct colors, reusing the same
ones more often.
Change most uses of black (
#000000) to#0D3349, which is the very dark blue we already used for the#qunit-headerbackground.Change text in
#qunit .passfrom#528CE0to#2F68DA, this is more saturated and appears darker. I also moved its hue slightly from cyan-blue, more toward blue-violet.Change the text color for
#qunit-testresultfrom#3B81AFto the same dark blue as used for module names,#366097. The color previously used here was a medium blue that we didn't use for any other text.Change the Rerun link from the near-invisible
#C2CCD1to instead inherit the text color of#qunit .passor#qunit .fail, e.g.#2F68DA. Also, to make it still stand out as special, add an underline. It retains its liberal padding for easy clickability.Clean up:
#qunit-header. Instead set it to that of#qunit-header a(it only contains a link), and let the latter inherit this color.#qunit-tests .fail .test-nameand and#qunit-tests .fail .module-namestyles.Ref #1427.