Indicate which test drooling assert.async callbacks came from #1599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more tightly scoped version of #1595, tackling only the
assert.async
callback error handling. The remainder (handling theonError
andglobal failure
scenarios) grew larger than expected, so I'd like to slice this part off for iterative improvements, and circle back on the more generic issues.The source change is straightforward.
Whenever a "done" callback is fired outside of the originating test, we currently see this:
We can tease that apart for 2 distinct use cases.
If we're in another test, we can use
pushFailure
to show:Or if we're outside of the tests, we can
throw
:I added a handful of tests - some to exercise these new paths, and some for related workflows by simply validating current behavior to avoid any unexpected changes, even if the current behavior is less than ideal.