Drop support for Python 3.7 #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phw thoughts? I don't feel that strongly about it. |
|
No strong opinion either. I don't see any pressing need to actively break compatibility. But no longer officially support and test 3.7 is reasonable. If upstream Python no longer supports the version I don't really see why a small project should still support it. From Picard side I think we will wait a bit more before we drop 3.7 from our tests. But mainly because the current 2.x Picard is supposed to offer as much compatibility with older OS as possible, while we will switch to Qt6 for Picard 3 and will be forced to upgrade minimum requirements quite a bit. |
|
ok, thanks for the feedback. Let's wait a bit more then. |
Merged
3.7 is EOL use 3.8.1 for poetry so we are compatible with flake8 v6
We depend on it in setup.py, but it's gone with Python 3.12, so make sure it's keeps being installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.7 is EOL