-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update dependencies and improve accessibility #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ACTCD
commented
Aug 6, 2023
- update development dependencies to latest version
- fixes emerging and previous eslint errors as well stylelint
- resolve numerous a11y errors to optimize accessibility
quoid
force-pushed
the
update_dependencies
branch
from
August 7, 2023 00:56
05cd297
to
27de5ae
Compare
quoid
reviewed
Aug 7, 2023
quoid
reviewed
Aug 7, 2023
quoid
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ACTCD This looks great, I just left one question. This can merged now, but I figured I will leave it open so you can answer the question a check my rebase against your changes.
@quoid Thanks for resolving the rebase and conflicts, it looks much better now! |
When the Extension Page is opened in a different window, the popup will not close automatically before switching back to the original window.
quoid
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.