Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update dependencies and improve accessibility #528

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Aug 6, 2023

  • update development dependencies to latest version
  • fixes emerging and previous eslint errors as well stylelint
  • resolve numerous a11y errors to optimize accessibility

@ACTCD ACTCD changed the base branch from main to native_update_logic August 6, 2023 21:55
Base automatically changed from native_update_logic to main August 6, 2023 21:55
src/shared/utils.js Outdated Show resolved Hide resolved
Copy link
Owner

@quoid quoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ACTCD This looks great, I just left one question. This can merged now, but I figured I will leave it open so you can answer the question a check my rebase against your changes.

@ACTCD
Copy link
Collaborator Author

ACTCD commented Aug 7, 2023

@quoid Thanks for resolving the rebase and conflicts, it looks much better now!

@ACTCD ACTCD requested a review from quoid August 7, 2023 08:41
When the Extension Page is opened in a different window, the popup will not close automatically before switching back to the original window.
@quoid quoid merged commit 1bdf8cd into main Aug 8, 2023
1 check passed
@ACTCD ACTCD deleted the update_dependencies branch August 8, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants